• Toni Barzic's avatar
    Don't leave tablet mode on lid event if tablet mode switch is on · 2e8c7c5a
    Toni Barzic authored
    Leaving tablet mode on lid state changes is a workaround for the lid
    being erroneously detected as fully open at small lid angles, which
    could cause the device to be detected as in tablet mode while opening
    the lid. This workaround should not override tablet mode state if
    tablet mode switch is on - this is a reliable indicator that the
    device actually is in tablet mode. Overriding this state could be
    problematic on detachable devices if the keyboard is detached while
    the lid is closed. In that case, the device could report lid as open
    after entering the tablet mode, and subsequently, and unexpectedly
    leave the tablet mode.
    
    BUG=b/79327284
    
    Change-Id: I31f2d31182122fc8a6a73e185360858e035118fe
    Reviewed-on: https://chromium-review.googlesource.com/1054370Reviewed-by: default avatarJonathan Ross <jonross@chromium.org>
    Reviewed-by: default avatarDan Erat <derat@chromium.org>
    Commit-Queue: Toni Barzic <tbarzic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#557650}
    2e8c7c5a
tablet_mode_controller.cc 22.1 KB