• Maggie Cai's avatar
    Revert "Always inject mocks for more hemertic InputMethodManagerImpl unit tests." · 2ecaaa59
    Maggie Cai authored
    This reverts commit 2b9c5c7c.
    
    Reason for revert: This CL is likely the root cause for build failure for linux-chromeos-dbg, starting from https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21474
    The failed tests are: InputMethodManagerImplTest.SetLoginDefaultWithAllowedKeyboardLayouts
    InputMethodManagerImplTest.TestEnableLayoutsNonUsHardwareKeyboard
    InputMethodManagerImplTest.TestEnableMultipleHardwareKeyboardLayout
    
    Original change's description:
    > Always inject mocks for more hemertic InputMethodManagerImpl unit tests.
    >
    > Six InputMethodManagerImpl tests are failing in specific environments
    > due to mixed usage of test data and CrOS prod configs. Partly caused by
    > inconsistent usage of MockComponentExtensionIMEDelegateManager. In
    > particular, parts of Setup() are run without this mock injected. The fix
    > here ensures the mock and its test data are consistently used throughout.
    >
    > With this we manage to un-fail 4 out of 6 tests, but another new test
    > starts failing! It's unsurprising because these tests still indirectly
    > depend on deprecated input_methods.txt configs (remnant from before the
    > migration to extension-based input methods circa 2011). This issue will
    > be addressed in the next steps.
    >
    > Bug: 970790
    > Change-Id: I3e76708e34f2b4e021f763654714d157f48a3925
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550152
    > Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org>
    > Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
    > Reviewed-by: John Palmer <jopalmer@chromium.org>
    > Reviewed-by: Darren Shen <shend@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#831198}
    
    TBR=ynovikov@chromium.org,shend@chromium.org,tranbaoduy@chromium.org,jopalmer@chromium.org
    
    Change-Id: I4fea5ebf6f46f66ba837d693f7970a0ac8949054
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 970790
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560527Reviewed-by: default avatarMaggie Cai <mxcai@chromium.org>
    Commit-Queue: Maggie Cai <mxcai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#831256}
    2ecaaa59
test_suite_exceptions.pyl 87.5 KB