• Tien Mai's avatar
    Reland "Include compatibility checks when submitting policy_templates.json." · 2ecc5c0e
    Tien Mai authored
    The original revert was done prematurely to fix a build break but this change was not the cause of the build break.
    
    This reverts commit 6c8601ff.
    
    Reason for revert: <INSERT REASONING HERE>
    
    Original change's description:
    > Revert "Include compatibility checks when submitting policy_templates.json."
    > 
    > This reverts commit d44d94c6.
    > 
    > Reason for revert: I think this is the cause for this tree-closing failure:
    > https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/7768
    > 
    > Original change's description:
    > > Include compatibility checks when submitting policy_templates.json.
    > > 
    > > This will change the presubmit checks for policy_templates.json to
    > > ensure that policy changes are backwards compatible with policies
    > > definitions that have already shipped.
    > > 
    > > Bug: 1026330
    > > Change-Id: If054d2376397432c66d948eaf0d2d42d5db13a0b
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925190
    > > Reviewed-by: Sergey Poromov <poromov@chromium.org>
    > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    > > Commit-Queue: Tien Mai <tienmai@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#721123}
    > 
    > TBR=pastarmovj@chromium.org,poromov@chromium.org,tienmai@chromium.org
    > 
    > Change-Id: I0ac66ee107a0ad25675e149192b47868653c525c
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1026330
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949265
    > Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
    > Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#721139}
    
    TBR=pastarmovj@chromium.org,poromov@chromium.org,takumif@chromium.org,tienmai@chromium.org
    
    Change-Id: I4ad04786c13ad4cf8be57399489e0bf311cd6fb6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1026330
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950744Reviewed-by: default avatarTien Mai <tienmai@chromium.org>
    Commit-Queue: Tien Mai <tienmai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#721471}
    2ecc5c0e
PRESUBMIT.py 10.8 KB