• Hayato Ito's avatar
    Revert "predictor: Switch to WebContentsObserver to observe resource loads." · 2f220c33
    Hayato Ito authored
    This reverts commit e9fcce49.
    
    Reason for revert:
    Findit identified the culprit r565609 with confidence 70.0%.
    See https://bugs.chromium.org/p/chromium/issues/detail?id=851232
    
    
    Original change's description:
    > predictor: Switch to WebContentsObserver to observe resource loads.
    > 
    > This CL is needed to make the preconnect predictor work with the Network
    > Service. The CL removes the LoadingPredictorObserver class that has been
    > notified by the ChromeResourceDispatcherHostDelegate and introduces instead the
    > LoadingPredictorTabHelper which implements the WebContentsObserver to notify
    > the predictor about resource loads.
    > 
    > All uses of the net::URLRequest and predictors::URLRequestSummary was replaced
    > by using the predictors::NavigationID or the content::mojom::ResourceLoadInfo.
    > 
    > The WebContentsObserver::ResourceLoadComplete() should work with and
    > without the Network Service, so we don't have to keep the old path.
    > 
    > Bug: 809583
    > Change-Id: I05c0aa97cfab1d773285633e6c5c3ef6a91367ca
    > Reviewed-on: https://chromium-review.googlesource.com/1039526
    > Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
    > Reviewed-by: Matt Menke <mmenke@chromium.org>
    > Reviewed-by: Lei Zhang <thestig@chromium.org>
    > Reviewed-by: Michael Wasserman <msw@chromium.org>
    > Reviewed-by: Benoit L <lizeb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#565609}
    
    TBR=msw@chromium.org,thestig@chromium.org,mmenke@chromium.org,lizeb@chromium.org,alexilin@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 809583
    Change-Id: If1bf3e4b6e98fbd716b9b994b0ee0c69cafc7036
    Reviewed-on: https://chromium-review.googlesource.com/1094955Reviewed-by: default avatarHayato Ito <hayato@chromium.org>
    Commit-Queue: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#565945}
    2f220c33
resource_hints_impl.cc 4.15 KB