• Will Harris's avatar
    Fix some 64-bit to 32-bit implicit conversions in chrome_elf. · 2f23243d
    Will Harris authored
    ../../chrome_elf/pe_image_safe/pe_image_safe.cc(76,75):  error: implicit conversion loses integer precision: 'long long' to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32]
      DWORD optional_header_offset = reinterpret_cast<char*>(optional_header) -
            ~~~~~~~~~~~~~~~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
    
    ../../chrome_elf/third_party_dlls/main.cc(77,54):  error: implicit conversion loses integer precision: 'std::vector<unsigned char, std::allocator<unsigned char> >::size_type' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32]
                         value_bytes.data(), value_bytes.size());
                                             ~~~~~~~~~~~~^~~~~~
    
    ../../chrome_elf/third_party_dlls/logs.cc(127,46):  error: implicit conversion loses integer precision: 'unsigned long long' to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                                : kMaxLogEntries - entries_.size();
                                  ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
    
    ../../chrome_elf/third_party_dlls/hook.cc(283,32):  error: implicit conversion loses integer precision: 'ULONG_PTR' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32]
      if (!GetDataFromImage(*base, *view_size, &time_date_stamp, &image_size,
           ~~~~~~~~~~~~~~~~        ^~~~~~~~~~
    
    BUG=588506
    
    Change-Id: I82abea7b741de1c56e9bcd1ce8c5bd59357ed20b
    Reviewed-on: https://chromium-review.googlesource.com/1184318
    Commit-Queue: Will Harris <wfh@chromium.org>
    Reviewed-by: default avatarPenny MacNeil <pennymac@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#585331}
    2f23243d
main.cc 4.65 KB