• oysteine's avatar
    Reland of Background tracing: Added config option for repeated trigger... · 2f4c6f2c
    oysteine authored
    Reland of Background tracing: Added config option for repeated trigger behavior (patchset #1 id:1 of https://codereview.chromium.org/2265423002/ )
    
    Reason for revert:
    Re-landing with fix
    
    Original issue's description:
    > Revert of Background tracing: Added config option for repeated trigger behavior (patchset #1 id:1 of https://codereview.chromium.org/2247033005/ )
    >
    > Reason for revert:
    > Test is flaky on builder "Android Tests"
    >
    > Builder: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests
    >
    > Failure:
    > https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/30899
    >
    > Output:
    > BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored (run #1):
    > [ RUN      ] BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored
    > [WARNING:dns_config_service_posix.cc(316)] Failed to read DnsConfig.
    > [ERROR:devtools_http_handler.cc(228)] Cannot start http server for devtools. Stop devtools.
    > ../../content/browser/tracing/background_tracing_manager_browsertest.cc:1210: Failure
    > Value of: BackgroundTracingManagerImpl::GetInstance()->IsTracingForTesting()
    >   Actual: false
    > Expected: true
    > ../../content/browser/tracing/background_tracing_manager_browsertest.cc:95: Failure
    > Value of: value
    >   Actual: true
    > Expected: expected
    > Which is: false
    > [  FAILED  ] BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored, where TypeParam =  and GetParam() =  (188 ms)
    > [----------] 1 test from BackgroundTracingManagerBrowserTest (188 ms total)
    >
    > Original issue's description:
    > > Background tracing: Add config option to control whether or not to stop reactive tracing when a repeated trigger occurs
    > >
    > > R=simonhatch@chromium.org
    > > BUG=637129
    > >
    > > Committed: https://crrev.com/fba230c24383ae08ea6d924401bdff81b46c7108
    > > Cr-Commit-Position: refs/heads/master@{#412577}
    >
    > TBR=simonhatch@chromium.org,ssid@chromium.org,petrcermak@chromium.org,oysteine@chromium.org
    > # Not skipping CQ checks because original CL landed more than 1 days ago.
    > BUG=637129
    >
    > Committed: https://crrev.com/ccb0f2af13bf3cc4ebdcdd7a08e19b281d788897
    > Cr-Commit-Position: refs/heads/master@{#413627}
    
    TBR=simonhatch@chromium.org,ssid@chromium.org,petrcermak@chromium.org,megjablon@chromium.org
    # Not skipping CQ checks because original CL landed more than 1 days ago.
    BUG=637129
    
    Review-Url: https://codereview.chromium.org/2285853002
    Cr-Commit-Position: refs/heads/master@{#414867}
    2f4c6f2c
background_tracing_manager_impl.cc 19.4 KB