• Filip Gorski's avatar
    [Omnibox][Incognito] Fix theme leaking in Incognito suggestions list · 2f6398f8
    Filip Gorski authored
    Adds a ripple definition specific to Incognito and changes where the
    selectable background is applied to DecoratedSuggestionView and action
    buttons.
    
    We logically have 3 possible sources of selection colors now:
    * Device light theme based
    * Device dark theme based
    * Incognito based (very similar to dark theme, but does not leak
      attributes).
    
    To better manage the 3 possible states this patch introduces
    OmniboxTheme with values { LIGHT_MODE, DARK_MODE, INCOGNITO }.
    
    To better resolve attribute values for the OmniboxTheme, this patch
    introduces OmniboxResourceProvider.
    
    All changes appropriately update USE_DARK_COLORS model property to
    OMNIBOX_THEME.
    
    Bug: 1103291
    Change-Id: I14f276274b25b6afa51ed7fbc3661a5437c5b1d0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288074
    Commit-Queue: Krishna Govind <govind@chromium.org>
    Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
    Reviewed-by: Ender 💬 = 🕐 (ping me for faster reviews) <ender@google.com>
    Reviewed-by: default avatarLijin Shen <lazzzis@google.com>
    Cr-Commit-Position: refs/heads/master@{#791375}
    2f6398f8
chrome_java_sources.gni 142 KB