• Christopher Cameron's avatar
    Add CHECKs to calls to IOSurfaceLookupFromMachPort · 2f800f06
    Christopher Cameron authored
    When allocating an anonymous IOSurface-backed GLImage, we have the
    sequence of calls
    - IOSurfaceCreate
    - IOSurfaceCreateMachPort
    - IOSurfaceRelease (implicitly in ScopedCFTypeRef<IOSurfaceRef>)
    - IOSurfaceLookupFromMachPort
    The final call persistently fails on some machines.
    
    This adds a CHECK when that call fails, so we can assess how often
    it occurs in the wild.
    
    This also adds a call to IOSurfaceCreateMachPort and
    IOSurfaceLookupFromMachPort before the implicit IOSurfaceRelease, to
    see if this may be the result of a reference counting bug.
    
    Add lots more LOG(ERROR) spew to help further diagnose this.
    
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Change-Id: Ie630067759d0bdf096be907986e53afdc632b15d
    Reviewed-on: https://chromium-review.googlesource.com/895142
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: default avatarVictor Miura <vmiura@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#533240}
    2f800f06
gl_image_io_surface.mm 14.8 KB