• Mario Bianucci's avatar
    Change flaky browser test to fail with more/better information · 2fa20960
    Mario Bianucci authored
    RenderWidgetHostDelegatedInkMetadataTest.
    FlagGetsSetFromRenderFrameMetadata is mildly flaky on various release
    builds, but I have not been able to repro it once across several
    thousand runs on win10 and linux chromeos. In an effort to try to get
    to the bottom of the issue, this CL slightly changes the test. The goal
    here is to make the test fail in a more obvious way if the issue is that
    the presenter promise did not resolve in time. With this change, if the
    promise hasn't been resolved, then updateInkTrailStartPoint will be
    called on a null presenter, so the error will be much more obvious.
    
    Bug: 1096994
    Change-Id: I45dd80bb22cbcd874c5c7412e9a91f8bf55b1399
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527823Reviewed-by: default avatarDaniel Libby <dlibby@microsoft.com>
    Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
    Commit-Queue: Mario Bianucci <mabian@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#826451}
    2fa20960
render_widget_host_browsertest.cc 37 KB