• vasilii@chromium.org's avatar
    Refactor BubbleDelegateView::use_focuseless(). · 2fe3a125
    vasilii@chromium.org authored
    It's confusing because it prevents the bubble activation. As a side effect on Windows the bubble doesn't get LBUTTON_DOWN messages. The reason for that is in HWNDMessageHandler::OnMouseActivate(). It asks the bubble if it can be activated. It answers "no" due to implementation in BubbleDelegateView::CanActivate(). Windows gets MA_NOACTIVATEANDEAT and MouseDown event isn't dispatched. This is definitely unexpected.
    The bubbles which indeed always inactive should use set_can_activate(false) at construction time.
    The bubbles which can be active but created without focus by default should use ShowInactive() instead.
    
    
    BUG=392734
    
    Review URL: https://codereview.chromium.org/413433002
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285682 0039d316-1c4b-4281-b951-d872f2087c98
    2fe3a125
mode_indicator_view.cc 2.88 KB