GitLab

This reverts commit 08c128cd.

Reason for revert: Reverterd on suspicion of causing build failures on Mac 10.11

TBR: carlosil@chromium.org

failures:
SSLClientSocketReadTest.Read/1
SSLClientSocketReadTest.Read/0
HTTPSEVCRLSetTest.FreshCRLSetNotCovered
WebSocketEndToEndTest.BasicSmokeTest
SSLClientSocketReadTest.DumpMemoryStats/0
SSLClientSocketReadTest.DumpMemoryStats/1
URLRequestTestFTP.FTPCheckWrongUser
WebSocketEndToEndTest.TruncatedResponse
WebSocketEndToEndTest.HstsWebSocketToWebSocket
WebSocketEndToEndTest.TrailingWhitespace
HTTPSOCSPTest.IntermediateResponseTooOld
URLRequestTestFTP.FTPCheckWrongUserRestart
URLRequestTestFTP.FTPCheckWrongPasswordRestart
HTTPSOCSPTest.Revoked
HTTPSFallbackTest.TLSv1_1NoFallback
HTTPSFallbackTest.TLSv1_3Interference
URLRequestTestFTP.FTPCheckWrongPassword
WebSocketEndToEndTest.HeaderContinuations
HTTPSCRLSetTest.ExpiredCRLSetAndRevoked
HTTPSEVCRLSetTest.FreshCRLSetCovered
SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/1
SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/0
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/18
HTTPSOCSPTest.Valid
HTTPSEVCRLSetTest.ExpiredCRLSet
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/13
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/10
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/11
OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/16
… 70 more (100 total) …

Original change's description:
> Refactor SSLCertificateErrorPageController
>
> SSLCertificateErrorPageController is no longer only used on SSL errors,
> renamed it to SecurityInterstitialErrorPageController, and removed the
> net::Error code passed to EnablePageHelperFunctions since it's no
> longer used.
>
> Bug: 910794
> Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Carlos IL <carlosil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#638232}

TBR=sky@chromium.org,mmenke@chromium.org,carlosil@chromium.org

Change-Id: I39489effa3e0029b5ff65f5bc9cbd991aef1ddea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 910794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507039Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638363}