• David Black's avatar
    Close holding space bubble when hiding holding space tray. · 30885888
    David Black authored
    It was previously assumed (at least by me) that hiding the holding
    space tray would result in closing of the holding space bubble. This
    was not actually guaranteed to be the case. This means that it was
    theoretically possible to keep the holding space bubble open even after
    detaching the holding space model and client, though I have not been
    able to reproduce this in the real world w/o forcing state
    programmatically. It's possible that a user was able to reach such a
    state which could result in the crash in the attached bug if interacting
    with the Files app chip.
    
    Bug: 1165305
    Change-Id: I039072d2d07eaf741ae70d551ac7889eaee0a46c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623726Reviewed-by: default avatarToni Baržić <tbarzic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#842636}
    30885888
holding_space_tray.cc 14.9 KB