• Karan Bhatia's avatar
    Revert "Add an optional boolean parameter in boundsForRange" · 30a5dcb8
    Karan Bhatia authored
    This reverts commit 7d96ee5f.
    
    Reason for revert:
    
    This broke assertions we make in the extensions docserver causing the
    docserver to stop updating. Several places (including extension
    bindings) depend on callbacks always being the last parameter to a
    function.
    
    Original change's description:
    > Add an optional boolean parameter in boundsForRange
    >
    > Current boundsForRange will clip the bounds to ancestors. This CL adds an
    > optional boolean parameter, clipped, to the boundsForRange method. The
    > default value of the parameter is true. When the clipped is set to false, the
    > bounds will not be clipped to the ancestors of the nodes.
    >
    > This CL is a part of the fix for bug 775659.
    >
    > Bug: 775659
    > Change-Id: I804637a2e6a8ec695dc176b88bd55d12fbc7f8a0
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335390
    > Commit-Queue: Lei Shi <leileilei@google.com>
    > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#795339}
    
    TBR=dmazzoni@chromium.org,dtseng@chromium.org,leileilei@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 775659, 1114299
    Change-Id: If9f19eb87f798afc10734cccd8b533ecd36bdacd
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343876
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#796202}
    30a5dcb8
automation_internal_custom_bindings.h 9.79 KB