• Kevin Bailey's avatar
    [omnibox] Narrow SetSelectedLineState() side-effects · 30a6be77
    Kevin Bailey authored
    When an Omnibox line goes to state button-selected, we called
    OnTemporaryTextMaybeChanged(). We did this because it happened to
    call SetAccessibilityLabel() and wasn't harmful in the general case.
    But it turns out to be harmful in some corner RTL cases, so this
    narrows it to solely the accessibility call.
    
    This required adding a sibling virtual method to OnTemporary...()
    of OmniboxView::SetAccessibilityLabel(). This only affects desktop
    platforms.
    
    Change-Id: If09b6870415522ce69caaf746186b7867611b7da
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895967Reviewed-by: default avatarmanuk hovanesian <manukh@chromium.org>
    Commit-Queue: Kevin Bailey <krb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#712262}
    30a6be77
omnibox_view_views.h 15.3 KB