-
Steven Bennetts authored
Originally landed then reverted because of null KeyboardController::Get() results in multi process mash tests: https://chromium-review.googlesource.com/c/chromium/src/+/1225853 Differences from the original CL: * ChromeKeyboardControllerClient::Get/SetKeyboardConfig added and used instead of keyboardController::Get() calls for multi process safety. * overscroll_override added to mojom::KeyboardConfig so that Get/SetKeyboardConfig can be used to configure it. This CL: * Moves the global mojom::KeyboardConfig instance and setter/getter to KeyboardController * Moves KeyboardControlEvent and LogKeyboardControlEvent to KeyboardController (which is the only consumer) * Moves overscroll override to KeyboardConfig * Removes keyboard::IsKeyboardVisible (only one non test call which already checks enabled() separately) * Moves InsertText to keyboard_controller.mojom * Makes some changes to KeyboardController to improve alignment of header definitions and implementations. * Removes keyboard_util.h from keyboard_controller.h and removes unnecessary keyboard_util.h includes. For trivial code removal from component_loader.cc: TBR=benwells@chromium.org Bug: 843332 Change-Id: I7a7843c47ae47dcdf5ebd623e353391b10962430 Reviewed-on: https://chromium-review.googlesource.com/c/1258088Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596796}
5f63c6b0