• Charlie Hu's avatar
    Add bool constructor with type for PolicyValue · 30d9990c
    Charlie Hu authored
    Previously, boolean PolicyValue is missing a constructor with type
    specification on PolicyValue class. It caused some inconvenience
    on code generation and testing. With the introduction of enum
    PolicyValue, this becomes more obvious because enum type's constructor
    also comes with a type parameter.
    
    In order to simplify the codegen and testing logic, this CL adds a dummy
    constructor for boolean type PolicyValue.
    
    Note: the constructor with type parameter aims to distinguish policy
    values that have same C++ type representation but different policy value
    type, e.g. IncDouble and DecDouble, Enum and Int.
    
    Change-Id: I11ba793c73a770d7211e21c6a94d29f5557ac284
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347365
    Commit-Queue: Charlie Hu <chenleihu@google.com>
    Reviewed-by: default avatarPhilip Jägenstedt <foolip@chromium.org>
    Reviewed-by: default avatarIan Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#798714}
    30d9990c
policy_value.cc 3.66 KB