• Alex Ilin's avatar
    Reland "[profiles] Don't show a profile being created in the picker and menu" · 310e38dd
    Alex Ilin authored
    This reverts commit e23f231d.
    
    Reason for revert: crash https://crbug.com/1169047 that was caused by the original version of this CL was fixed
    
    Original change's description:
    > Revert "[profiles] Don't show a profile being created in the picker and menu"
    >
    > This reverts commit e2de939b.
    >
    > Reason for revert: causes crash https://crbug.com/1169047
    >
    > Original change's description:
    > > [profiles] Don't show a profile being created in the picker and menu
    > >
    > > This CL leverages the already existing kIsOmittedFromProfileListKey
    > > preference in ProfileAttributesEntry to mark profiles that shouldn't
    > > be shown to the user.
    > >
    > > kIsOmittedFromProfileListKey was created for profiles in the middle of
    > > being set up as new legacy supervised users. The preference was dead
    > > because it was never set to true. This CL revives it and adds additional
    > > checks to profile_picker_handler.cc and profile_menu_view.cc to not
    > > display omitted profiles.
    > >
    > > Bug: 1126913, 1166809
    > > Change-Id: Ieb05f31d8951f2971201351bead7c108eb874473
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632752
    > > Commit-Queue: Alex Ilin <alexilin@chromium.org>
    > > Reviewed-by: David Roger <droger@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#845372}
    >
    > TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    >
    > Change-Id: I5133c4502f02b68c4e707fa7c86072bdabce4ff2
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1126913
    > Bug: 1166809
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642328
    > Reviewed-by: Alex Ilin <alexilin@chromium.org>
    > Commit-Queue: Alex Ilin <alexilin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#845616}
    
    TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1126913
    Bug: 1166809
    Change-Id: I8aba3d3ffef4e01a51228d449e7e0bac24b8f7f0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642329Reviewed-by: default avatarDavid Roger <droger@chromium.org>
    Commit-Queue: Alex Ilin <alexilin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#845667}
    310e38dd
BUILD.gn 396 KB