GitLab

This reverts commit 4856b612.

Reason for revert:

New test is failing on windows asan.
https://ci.chromium.org/p/chromium/builders/ci/win-asan/13719

[ RUN      ] All/DumpAccessibilityEventsTest.AccessibilityEventsAriaHiddenDescendantsAlreadyIgnored/win

DevTools listening on ws://127.0.0.1:56078/devtools/browser/cb8ef55e-fd6c-40c9-9bb9-69a6e2f10a39
[3056:12476:0805/095807.582:ERROR:browser_test_utils.cc(712)] No committed entry.
[3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged
[3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kLayoutComplete
[3056:12476:0805/095810.629:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kLoadComplete
[3056:12476:0805/095810.693:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged
[3056:12476:0805/095810.694:ERROR:dump_accessibility_events_browsertest.cc(103)] === IsRecordingComplete#1 run_until size=0
[3056:12476:0805/095810.703:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged
[3056:12476:0805/095810.856:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kChildrenChanged
[3056:12476:0805/095810.857:INFO:accessibility_notification_waiter.cc(147)] OnAccessibilityEvent Event::kEndOfTest
[3056:12476:0805/095810.866:INFO:dump_accessibility_test_helper.cc(93)] Testing: C:/b/s/w/ir/content/test/data/accessibility/event/aria-hidden-descendants-already-ignored.html
[3056:12476:0805/095810.867:INFO:dump_accessibility_test_helper.cc(95)] Expected output: C:/b/s/w/ir/content/test/data/accessibility/event/aria-hidden-descendants-already-ignored-expected-win.txt
[3056:12476:0805/095810.867:ERROR:dump_accessibility_test_helper.cc(127)] Diff:
* Line Expected
- ---- --------
     1 EVENT_OBJECT_HIDE on <div#heading-root.a> role=ROLE_SYSTEM_GROUPING name="Heading" INVISIBLE level=2
     2 EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL
*    3 IA2_EVENT_TEXT_INSERTED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL new_text={'<obj>' start=0 end=1}
*    4 IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1}

Actual
------
EVENT_OBJECT_HIDE on <div#heading-root.a> role=ROLE_SYSTEM_GROUPING name="Heading" INVISIBLE level=2
EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL
EVENT_OBJECT_REORDER on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL
IA2_EVENT_TEXT_INSERTED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL new_text={'<obj>' start=0 end=1}
IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1}
IA2_EVENT_TEXT_REMOVED on <div> role=ROLE_SYSTEM_TOOLBAR IA2_STATE_HORIZONTAL old_text={'<obj>' start=0 end=1}
<-- End-of-file -->



Original change's description:
> Fire WIN HIDE event only on ignored ancestor
> 
> Google drive expand/collapse state is not being announced due to
> excessive HIDE/SHOW/REORDER events flooding NVDA, and NVDA end up
> discarding most events.
> 
> For example, if aria-hidden="true" is set on an ancestor node, which
> would cause that node many of its descendants to be set to IGNORED
> state which triggering too many EVENT_OBJECT_HIDE and causes NVDA
> to drop the events. In reality, we only want EVENT_OBJECT_HIDE to be
> generated on the ancestor node where aria-hidden="true" is set, so
> not to flood and confuse NVDA with excessive events.
> 
> This change fixes the above issue by firing EVENT_OBJECT_HIDE on the
> root should the entire subtree changes to IGNORED state.
> 
> Suppressing excessive SHOW/REORDER events will be addressed in follow up
> patches.
> 
> AX-RelNotes: NVDA can now announce Google drive "My Drive" expand/
> collapse state.
> 
> Bug: 1019420
> Change-Id: I4fdabd6740630a149c1b22cdb3180d2f75807b10
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309450
> Commit-Queue: Victor Fei <vicfei@microsoft.com>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#795017}

TBR=dmazzoni@chromium.org,aleventhal@chromium.org,Adam.Ettenberger@microsoft.com,vicfei@microsoft.com

Change-Id: I4354e1effb7b3fe4a01caef00f696513ecaacbbc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339828Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795159}