• Ian Vollick's avatar
    [vr] Add not-web-exposed media feature for immersive mode. · 31c3e864
    Ian Vollick authored
    With this change, I've added a media feature that returns true when
    in immersive mode (eg, in VR). I've added extra plumbing to ensure that
    this new feature is not web exposed.
    
    More info on media features here:
    https://www.w3.org/TR/css3-mediaqueries/#media1
    
    The plumbing for this particular feature is very close to the plumbing
    for -webkit-transform-3d.
    
    I've also changed the "page popups suppressed" setting (which was only
    ever true in immersive mode) to be named immersive, accordingly.
    However, the uses of the immersive mode setting for suppressing page
    popups are meant to be temporary, so I've added comments referencing
    the bug that explains the removals.
    
    Bug: 809021
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Change-Id: Ib46237b7c7f518830d0134c51baefeb3a1d89c11
    Reviewed-on: https://chromium-review.googlesource.com/901484Reviewed-by: default avatarRick Byers <rbyers@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
    Commit-Queue: Ian Vollick <vollick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#534497}
    31c3e864
render_view_impl.cc 95.2 KB