GitLab

AwDebug.dumpWithoutCrashing was added to diagnose a suspected renderer
hang; it's only accessible by reflection and has not been used to debug
an issue for a long time. It no longer provides very useful output since
it only dumps the current process and WebView is now multiprocess in the
majority of cases.

Therefore, just disable the API entirely rather than making it more
complex to support multiprocess - if there's a similar need in future it
would be more useful to support capturing a trace than a minidump, which
did not prove valuable. We keep it around so that any hypothetical
clients won't see exceptions during reflection (though they should be
handling those exceptions) - it just always returns false to indicate
the dump was not generated.

AwDebugTest relied on dumpWithoutCrashing to test the crash key
filtering mechanism, but the tests have been disabled for some time and
maintaining this just for a test doesn't seem worth it; just remove
those disabled tests entirely.

Fixed: 568825
Fixed: 913515
Change-Id: I2b5b242388d6aaac14508f554e58c3eabbc4ae5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231658Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775297}