GitLab

To support the secondary buttons focusing, unfocusing, and triggering
via keyboard, the OmniboxViewViews calls into OmniboxResultView via
OmniboxPopupContentsView.

In retrospect, this was a mistake, to have one View invasively start
poking into the internal state of another. We should have had both Views
interact only with OmniboxPopupModel, which is where orinj's refactor
is going.

This is leading to some Windows-only crashes, I'm guessing because
Windows has some platform-specific window manager logic that's
unexpectedly closing the popup - although I am not sure.

This is a somewhat speculative fix. Were it not for COVID, I would be
diving into the minidumps using Visual Studio and I would have a more
informed opinion of what's going on.

The ultimate solution though, is orinj's OmniboxPopupModel refactor.

Bug: 1063071
Change-Id: I33c916b86c3a7e0fbf2d3edff5732eeb4936124c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122907
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753815}