• David Bokan's avatar
    Reland "Do not coalesce wheel with phaseBegan to wheel with phaseEnded." · 35699cea
    David Bokan authored
    This reverts commit 5dd16566.
    
    Reason for revert: This CL was confirmed to be the cause of the perf
    regression in crbug.com/978980 - this is artificial so we can reland
    
    Original change's description:
    > Revert "Do not coalesce wheel with phaseBegan to wheel with phaseEnded."
    >
    > This reverts commit 2ca01526.
    >
    > Reason for revert: Speculative revert for https://crbug.com/978980
    >
    > Original change's description:
    > > Do not coalesce wheel with phaseBegan to wheel with phaseEnded.
    > >
    > > If no element in the scrolling chain is not scrollable in the given direction
    > > (delta_hints) on GSB we latch to the viewport. This is not user friendly on
    > > platforms that do not have any scroll affordance animations (e.g. Windows)
    > > since if the user changes the scrolling direction and an element in the chain
    > > is actually scrollable in the new direction, the user expects it to scroll and
    > > has no idea that we have latched to the (possibly unscrollable) viewport for
    > > the rest of the scroll sequence. To address the issue for timer based wheel
    > > scroll sequence we end the sequence and start a new one upon arrival of a wheel
    > > event with different delta directions if no GSU has been consumed since the
    > > beginning of the sequence. This cl ensures that the GSE/GSB generated for
    > > breaking the latching seqeunce are not coalesced with each other.
    > >
    > > Bug: 882998
    > > Change-Id: Icf703c935475fffd69b899c59abc03ec1b548784
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524703
    > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    > > Commit-Queue: Sahel Sharify <sahel@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#641719}
    >
    > TBR=nzolghadr@chromium.org,sahel@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 882998,978980
    > Change-Id: I85799b6e6eace029b4c2ef00e142f035ac9e8e4c
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688230
    > Reviewed-by: David Bokan <bokan@chromium.org>
    > Commit-Queue: David Bokan <bokan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#674615}
    
    TBR=bokan@chromium.org,nzolghadr@chromium.org,sahel@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 882998, 978980
    Change-Id: I3dfb3f3ec0467b7101597720325222899e46f10b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716444Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
    Commit-Queue: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#680315}
    35699cea
blink_event_util_unittest.cc 19.1 KB