-
Sam Maier authored
Testing done using is_java_debug=false, on patchset #6: - Ran Monochrome.apks with just the base module, went to a few webpages - Ran ChromeModernPublic.apks with base module only, few webpages - Ran Monochrome.apks with base and ar modules, opened AR and it worked - Ran ChromeModernPublic.apks with base and ar modules, ran VR fine - Unzipped the .aab files, compared the dex files to current master: * base/classes.dex files were byte-for-byte identical for both Monochrome and ChromeModernPublic * ar/classes.dex file in Monochrome was a bit smaller. In total, we went from 170->119 methods, 88->70 types, 27->21 fields, 260->213 strings * vr/classes.dex file in ChromeModernPublic was a bit smaller. We went from 1088->1030 methods, 330->316 types, 277->270 fields, 987->951 strings Since the base/classes.dex files were identical, and the vr and ar modules worked, I have good confidence that this is functional. Bug: 883162 Change-Id: Id1100193a0787c38680a63fe3b5f85a1c10ef926 Reviewed-on: https://chromium-review.googlesource.com/c/1327571 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610884}
3599daa6