• Jiawei Li's avatar
    Revert "[chromecast] Enable element focus for WebContentController" · 35f4110b
    Jiawei Li authored
    This reverts commit ffc6f22e.
    
    Reason for revert: key events cannot reach its target with this change. Particular app cannot adjust volume via button.
    
    Bug: Internal b/162242786
    Test: manual on device
    
    Original change's description:
    > [chromecast] Enable element focus for WebContentController
    > 
    > Focus did not work due to two distinct problems, both of which caused
    > page-level focus to be absent, which in turn meant that blink-level
    > focus was suppressed.
    > 
    > - The aura::Window on which focus was attempted does not have an
    >   OnWindowFocused observer. This change focuses the Window that does.
    > 
    > - Wayland app's aura::Windows are not visible. This change adds a check
    >   for an ancestor that is an exo window.
    > 
    > Bug: b/156123509
    > Test: manual on device
    > Change-Id: Ib4e8a5101bbc28d2b7a0448aff8142c8cffa2a76
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274201
    > Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
    > Reviewed-by: Albert Chaulk <achaulk@chromium.org>
    > Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#786469}
    
    TBR=achaulk@chromium.org,dnicoara@chromium.org,kpschoedel@chromium.org,dcastagna@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: b/156123509
    Change-Id: Ifd988ad2469c2797d43e74c9194f2b28b7c31753
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335395
    Commit-Queue: Jiawei Li <lijiawei@chromium.org>
    Reviewed-by: default avatarLuke Halliwell (slow) <halliwell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#794641}
    35f4110b
cast_focus_client_aura.cc 7.98 KB