• v.putkinen's avatar
    telemetry: Fix runaway subprocess in monsoon_power_monitor.py · 362315d0
    v.putkinen authored
    Telemetry leaves a memory hogging subprocess behind if:
    1) A Monsoon Power Monitor is attached to host computer (Linux),
    2) User runs a power-metric-using benchmark such as sunspider on Android
       ChromeShell, and
    3) Benchmark raises an exception between power metric's Start and Stop
       calls. For example, an exception will occur if browser crashes and
       the benchmark does something like tab.WaitForJavaScriptExpression().
    
    This patch fixes the issue by setting the daemon flag on the subprocess.
    This will cause the main process to kill the subprocess on exit.
    
    BUG=413596
    
    R=ernstm@chromium.org
    
    Review URL: https://codereview.chromium.org/572643002
    
    Cr-Commit-Position: refs/heads/master@{#296177}
    362315d0
AUTHORS 18.6 KB