GitLab

This reverts commit 14f12b97.

Reason for revert: As mpearson pointed out, this CL has an unintended affect on HQP suggestions.

This is a partial revert. A full revert would fail tests due to other
changes since the original CL landed. This revert keeps test changes
from the original CL and updates another test. Additionally, it retains
a variable rename and formatting change since those have no functional
effect and we prefer the newer versions.

Original change's description:
> [omnibox] Dedup history matches HQP matches.
>
> This CL filters duplicate history matches in
> URLIndexPrivateData::HistoryItemsForTerms used by the HQP. Previously,
> we relied on the autocomplete controller's deduping which
> 1) may affect performance since it occured after additional processing
> of each suggestion (I would guess it's insignificant), and
> 2) prevented the HQP provider from making full use of it's allocated
> per-provider-limit.
>
> Also update a few HQP unit tests.
>
> Bug: 591981
> Change-Id: I1c6ce02050ba1b674e3507368c1a095f5a5b0c6d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219027
> Commit-Queue: manuk hovanesian <manukh@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#773185}

TBR=tommycli@chromium.org,jdonnelly@chromium.org,manukh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 591981
Change-Id: I00ad1ebdcb40163b0eb488dd5771f1b703566aeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327955Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796553}