• cevans@chromium.org's avatar
    The correct type for the size of a chunk of memory is size_t. · 374f1a83
    cevans@chromium.org authored
    By using uint32, we have bugs on 64-bit platforms: callers passing in a size_t, will have their size truncated, potentially allocating a smaller
    chunk than requested. There are a few places this happens, including on the
    receiving ends of IPCs(!)
    
    However, coversely, other callers of the API might directly assign the
    memory chunk's length to uint32, leading to a different possible truncation
    problem. This is guaraded against by limiting operations internally to
    std::numeric_limits<uint32_t> in size for now.
    
    There's some minor cascade effects that make the CL look larger than it is.
    
    BUG=164678
    Review URL: https://codereview.chromium.org/11446048
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175987 0039d316-1c4b-4281-b951-d872f2087c98
    374f1a83
shared_memory_nacl.cc 3.19 KB