• Gauthier Ambard's avatar
    Revert "[iOS] Set FirstResponderSendAction as default" · 3805470b
    Gauthier Ambard authored
    This reverts commit 2aa1a2f6.
    
    Reason for revert: Potential culprit for crbug.com/1152587
    
    Original change's description:
    > [iOS] Set FirstResponderSendAction as default
    >
    > Remove experiment flag, and set enabled behavior as default.
    >
    > Keep old behavior when asking the NTP and WebView to become first
    > responder. This is done checking if the first responder is a view, and
    > asking if not. Because in the previous logic for GetFirstResponder() the
    > search was made in the view hierarchy, ignoring view controllers.
    >
    > The experiment enabled without the check added in this CL could explain
    > issues like crbug.com/1150498.
    >
    > Bug: 816427, 1150498
    > Change-Id: Ib9ac17b59da8635d00beff071aee4bd6afeedb78
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495976
    > Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    > Commit-Queue: Javier Flores <javierrobles@chromium.org>
    > Auto-Submit: Javier Flores <javierrobles@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#830632}
    
    TBR=gambard@chromium.org,javierrobles@chromium.org
    
    Change-Id: If4c1451b7ed278b02164f0816d8b01bf11314289
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 816427
    Bug: 1150498
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560097Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#830927}
    3805470b
uikit_ui_util.mm 13.9 KB