-
Findit authored
This reverts commit fdd7489f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 680383 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmRkNzQ4OWYxZjk1YTk4NDM3MWMwM2UxMThmZjE3YTQ2MGM2NTlmOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/55141 Sample Failed Step: content_browsertests Sample Flaky Test: BackForwardCacheBrowserTest.LoadingSubframeDoesNotPreventCaching Original change's description: > [bfcache] Don't cache pages that are still loading. > > To avoid the complexity of caching and restoring still-loading pages, > for now simply don't cache pages that haven't finished loading. > > Long term this logic will probably need to be extended to be more > complicated/permissive, to increase back-forward cache coverage. > > Change-Id: Ic06d9b3d425d3df95b8d09bea1561c000a96acc4 > Bug: 976697 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692414 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Lowell Manners <lowell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680383} Change-Id: Iedaebe0c40be92b34e2ad8d6ea650eb06044e2f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715263 Cr-Commit-Position: refs/heads/master@{#680565}
381033f4