GitLab

views wants to (more or less) own the DialogDelegate. This is currently
done via refcounting. To remove that dependency of the refcounts,
extract it into its own object, with lifetime contracts against
LoginHandler.

Now the threading and refcounting mess is largely confined to the
LoginHandler base class, rather than spread into the subclasses.

Bug: 908926
Change-Id: Ia7f88c23d051dff06492baee2b050f82265a59e3
Reviewed-on: https://chromium-review.googlesource.com/c/1388037Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626194}