• Anatoliy Potapchuk's avatar
    Reland "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably" · 39a8ab18
    Anatoliy Potapchuk authored
    This reverts commit 0e5a5146.
    
    Reason for revert: Fixed errors in AppLaunchController. Time refactor all of this.
    
    Original change's description:
    > Revert "[Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably"
    >
    > This reverts commit cdce07c9.
    >
    > Reason for revert: KioskTest.LaunchAppWithNetworkConfigAccelerator has been failing on msan fairly consistently since this landed:
    > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17653
    >
    > Original change's description:
    > > [Kiosk] Refactor AppLaunchSplashScreenHandler so it works more reliably
    > >
    > > This handler was little bit overcomplicated. This led to a bug in web
    > > kiosk mode when we update network state, but do not update the handler.
    > >
    > > Because of this convolution, in web kiosks, the network configure
    > > screen did not update itself when connected to network(which is what
    > > client will expect from the handler which observes network state).
    > > Now it behaves more logically and predictably.
    > >
    > > Bug: 1015383
    > > Change-Id: I78b024b1d51b54b0d01d0a5a5694f6ae3f5ac19e
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031406
    > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
    > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
    > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#739128}
    >
    > TBR=xiyuan@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 1015383
    > Change-Id: Ibc08de19048d9c8af95c3f517b748d09e37c7597
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045479
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Commit-Queue: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#739735}
    
    TBR=xiyuan@chromium.org,thakis@chromium.org,rsorokin@chromium.org,apotapchuk@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1015383
    Change-Id: Ie77ba40fa6bf3bc94a22c97a8d2b0764ef0614d8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047225Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
    Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#745056}
    39a8ab18
app_launch_controller.cc 18.6 KB