• leviw@chromium.org's avatar
    2011-03-16 Levi Weintraub <leviw@chromium.org> · 39af8b67
    leviw@chromium.org authored
            Reviewed by Ryosuke Niwa.
    
            REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
            https://bugs.webkit.org/show_bug.cgi?id=56407
    
            Creating three versions of the iframe-onload-crash test to cover all editing behaviors.
    
            * editing/style/iframe-onload-crash-expected-mac.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
            * editing/style/iframe-onload-crash-expected-unix.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
            * editing/style/iframe-onload-crash-expected-win.txt: Copied from LayoutTests/editing/style/iframe-onload-crash-expected.txt.
            * editing/style/iframe-onload-crash-expected.txt: Removed.
            * editing/style/iframe-onload-crash-mac.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
            * editing/style/iframe-onload-crash-unix.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
            * editing/style/iframe-onload-crash-win.html: Copied from LayoutTests/editing/style/iframe-onload-crash.html.
            * editing/style/iframe-onload-crash.html: Removed.
            * platform/chromium/test_expectations.txt:
            * platform/gtk/Skipped:
            * platform/win/Skipped:
    2011-03-15  Levi Weintraub  <leviw@chromium.org>
    
            Reviewed by Ryosuke Niwa.
    
            REGRESSION (r81165): Assert running editing/style/iframe-onload-crash.html with non-Mac editing behavior
            https://bugs.webkit.org/show_bug.cgi?id=56407
    
            Fixing the creation of incorrect ranges from TextIterator due to passing node/offset pairs that
            weren't parent-anchored. Also changing canHaveChildrenForEditing to properly handle nodes that
            have had children appended to them that editing wouldn't normally allow.
    
            Tests: editing/style/iframe-onload-crash-mac.html
                   editing/style/iframe-onload-crash-unix.html
                   editing/style/iframe-onload-crash-win.html
    
            * editing/TextIterator.cpp:
            (WebCore::TextIterator::rangeFromLocationAndLength): Passing parent-anchored values to range.
            * editing/htmlediting.cpp:
            (WebCore::canHaveChildrenForEditing): Adding a condition that the nodes don't already have children
            for hr and datagrid, as you can append any node to another using javascript.
    
    
    git-svn-id: svn://svn.chromium.org/blink/trunk@81266 bbb929c8-8fbe-4397-9dbb-9b2b20218538
    39af8b67
Skipped 54.4 KB