• Ioana Pandele's avatar
    [Android] Refactor PasswordManagerDialog · 39e60ba2
    Ioana Pandele authored
    The method called to show the dialog used to take 9 parameters and the
    list was growing. This CL bundles the parameters into a separate contents
    object which requires the mandatory values to be passed in the constructor
    and offers reasonable defaults and setters for the rest of the values.
    
    In addition, some properties of the model are not actually meant to be
    changed on the fly, so they are now marked readonly and set before building
    the model. This requires a separate initialization step in the coordinator
    and mediator.
    
    Bug: 1028947
    Change-Id: I4f121e5fee88d095d6c31add59111639e85faedb
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948931
    Commit-Queue: Ioana Pandele <ioanap@chromium.org>
    Reviewed-by: default avatarFriedrich [CET] <fhorschig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#721576}
    39e60ba2
chrome_java_sources.gni 151 KB