GitLab

Move visual_utils code and tests from components/safe_browsing/
content/password_protection to compontents/safe_browsing/core/
common/. The code for visual_utils currently lives in
components/safe_browsing/content/password_protection/, but is now
used by both password_protection and phishing_classifier code,
therefore this CL moves the files and tests to the common/ directory.

This solves the assert_no_deps issue and allows to remove the
"nogncheck" in scorer.h when depending on the
"c/s_b/c/password_protection" target from the phishing_classifier
(which is in deps for chrome/renderer/BUILD.gn), see crbug.com/1138547
for details.

BUG=1138547,1136950

Change-Id: Ic3796eec31c32ff6aee9e9267fbbebb0be090ef7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495066Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822278}