GitLab

I stumbled upon the need for some cleanup in deadlines while investigating
a surface sync bug.

SurfaceDependencyDeadline::InheritFrom returned a bool that wasn't
used anywhere anymore. This CL removes it.

This CL also clarifies the InheritFrom contract. When deadline object
A inherits from deadline object B, A gets B's deadline but does not
get B's start time. This was already true but this CL adds direct test
coverage of this.

The other oddity is InheritFrom only supported deadline inheritance if
the object already had a deadline set. This is how it's used by surface
sync in practice but seems unnecessarily brittle. With a small change,
the contract is fully specified and this special case is removed.

Bug: 672962
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Icd6a078ef90298af578c7267ca38f5c0f3ab5d37
Reviewed-on: https://chromium-review.googlesource.com/964257
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543447}