• Darren Shen's avatar
    [VK] Clarify occluded vs visual bounds in NotificationManager. · 3a97998d
    Darren Shen authored
    NotificationManager::SendNotifications takes an argument
    |bounds_affect_layout|, but it's unclear from the name what type of
    bounds it is. The sole caller of SendNotifications uses occluded bounds,
    so we assume that that's the intention.
    
    (occluded) |bounds_affect_layout| is used to determine what the
    displaced bounds are. Our naming change exposes a "bug": if the
    occluded bounds affect layout, we set the displaced bounds to the
    visual bounds. This is not right; we should be using the occluded
    bounds. This makes sense, because for future features like fullscreen
    handwriting where the visual bounds fill the entire screen, we should
    only displace what is actually occluded.
    
    TBR=blakeo@chromium.org
    
    Change-Id: Ie6a9d04294cba5b4bf23009f9300698e2946079f
    Reviewed-on: https://chromium-review.googlesource.com/1146526Reviewed-by: default avatarDarren Shen <shend@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#577456}
    3a97998d
notification_manager.cc 3.32 KB