• Trent Apted's avatar
    Fix WidgetTest.ChildStackedRelativeToParent on 10.13 · 3aa7e668
    Trent Apted authored
    Since 10.13, a trip to the runloop seems to be been necessary to ensure
    [NSApp orderedWindows] updates inside WidgetTest::IsWindowStackedAbove().
    
    Unforunately, flushing the runloop exposes the test to window server
    events which can cause asynchronous activation events to be interleaved
    with other parts of the test. To deflake, run the test interactively,
    and sync with the window server whenever a new window is raised.
    
    Earlier attempt in https://crrev.com/c/590332 caused flakes on 10.12.
    
    Bug: 749905
    Change-Id: Ifde8800e0966233cfeea41515b66b0fc2926317d
    Reviewed-on: https://chromium-review.googlesource.com/899806Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#534582}
    3aa7e668
widget_unittest.cc 137 KB