GitLab

There are two branches currently:
- if at least one user has a maximized window, fade shelf to black
  and back. Note that this branch is broken, and instead all you see is
  a white flash, but this is easily fixed if need be.
- otherwise, set shelf to hidden and then let the user switch update the
  state from there.

If we remove both of these branches and just let the user switch change
the state of the shelf, the outcome is nearly indistinguishable.
Scratching the second bullet point above seems to have no discernible
effect. Scratching the first branch just means there will be no fade-to-
black, however the addition and removal of launcher icons is animated
regardless, so it still looks smooth. Additionally, the fade-to-black
doesn't work on the system tray (clock, avatar), and hasn't worked at
all for 4 months and no one noticed. In a sense, removing this branch is
an improvement because it removes a white flash.

Bug: 756085
Change-Id: If40c65e02035947709be31db466dea144ab0b462
Reviewed-on: https://chromium-review.googlesource.com/683035
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504363}