• Donn Denman's avatar
    Revert "[TTS] Write snippet to UKM for offline development" · 3adbd43b
    Donn Denman authored
    This reverts commit 0036bbd0.
    
    Reason for revert: Ran out of time to try the development pipeline
    
    DETAILS: Just whitespace changes from the original.
    
    Original change's description:
    > [TTS] Write snippet to UKM for offline development
    >
    > Writes a snippet-hash and doc-id to UKM iff a command-line flag is
    > set that allows this development-only data to be logged. Disabled
    > on Beta and Stable channels.
    >
    > See go/ukm-cs-5, go/ukm-dev-data, go/cs-sanitized for details.
    >
    > Unfortunately our ContextualSearchDelegate cannot decode a JSON 64bit value
    > so we now expect to receive these new data in string format.
    >
    > Also fix a bug in the existing Ranker code: the native logger cannot log
    > 64-bit values, so we rename some misleading methods.  Also, we need to break
    > these new data up into high/low 32-bit values when we log to Ranker.
    >
    > BUG=894568, 872902
    >
    > Change-Id: Id0dd3ac218bafeb23396f010c340e5e5531799f0
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264591
    > Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
    > Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
    > Reviewed-by: Theresa <twellington@chromium.org>
    > Reviewed-by: Andrew Moylan <amoylan@chromium.org>
    > Commit-Queue: Donn Denman <donnd@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599258}
    
    TBR=rkaplow@chromium.org,donnd@chromium.org,twellington@chromium.org,amoylan@chromium.org,rhalavati@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 894568, 872902
    Change-Id: I99cc44bf1f89cace8548957e75acbcdd2cfe9afa
    Reviewed-on: https://chromium-review.googlesource.com/c/1308102
    Commit-Queue: Donn Denman <donnd@chromium.org>
    Reviewed-by: default avatarDonn Denman <donnd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#604161}
    3adbd43b
contextual_search_delegate.h 8.42 KB