GitLab

Since the file is now written in binary mode, newline translation is no longer a concern and is consistent across platforms.

[14/39932] ACTION //chrome/browser/resources/settings:modulize(//build/toolchain/win:win_clang_x64)
Traceback (most recent call last):
  File "../../ui/webui/resources/tools/js_modulizer.py", line 154, in <module>
    main(sys.argv[1:])
  File "../../ui/webui/resources/tools/js_modulizer.py", line 150, in main
    ProcessFile(os.path.join(in_folder, f), out_folder, namespace_rewrites)
  File "../../ui/webui/resources/tools/js_modulizer.py", line 128, in ProcessFile
    f.write(unicode(l, 'utf-8'))
NameError: name 'unicode' is not defined

Bug: 941669
Change-Id: I7aa0aa834944e4505f9045026e3d32315740140b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033509
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#738256}