-
Eric Orth authored
Made `RecordParsed::rdata_` nullable but missed a deref in `RecordParsed::IsEqual()`. Original change's description: > Revert "Ignore unknown record types in DNS responses" > > This reverts commit e4620991. > > Reason for revert: Suspected for causing crashes on Windows/Intel. > For more info see bug. > > Bug: 1148269 > > Original change's description: > > Ignore unknown record types in DNS responses > > > > Previously worked only for address requests. Other request types (e.g. > > HTTPS), on seeing any unrecognized (and therefore unparsable) record > > type in the response, would fail the whole response as malformed. > > > > Bug: 1147247 > > Change-Id: Icd9e5ab2e39cf09ffe7c3945b011ebf1d4b45778 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529619 > > Commit-Queue: Eric Orth <ericorth@chromium.org> > > Auto-Submit: Eric Orth <ericorth@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#826462} > > TBR=mmenke@chromium.org,ericorth@chromium.org > > Change-Id: I03ea912d1a9c8a01be3d84a3f4d417c385f97c2d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1147247 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533548 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826873} Bug: 1148269,1147247 Fixed: 1147247 Change-Id: I312c095e519c62d730e5fb6165833727f5d913be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534629 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#827004}
3b26e3ba