• Patrik Höglund's avatar
    Revert "Don't make a LayerTreeFrameSink for a non-visible RenderWidget." · 3b39a541
    Patrik Höglund authored
    This reverts commit 68d8dbc0.
    
    Reason for revert: Looks like it makes PrerenderBrowserTest.PrerenderInfiniteLoop according to FindIt. 
    
    ../../chrome/browser/prerender/prerender_browsertest.cc:1721: Failure
    Expected equality of these values:
      1U
        Which is: 1
      GetLinkPrerenderCount()
        Which is: 2
    
    Original change's description:
    > Don't make a LayerTreeFrameSink for a non-visible RenderWidget.
    > 
    > Importantly, non-visible RenderWidgets include swapped out RenderWidgets
    > which are zombies, without a frame, and which should not be used.
    > 
    > This can happen if the RenderWidget swap out races with the posted task
    > from the compositor to make a LayerTreeFrameSink. When swapping out, the
    > compositor would be marked as not-visible, which would stop it from
    > making such requests, but one could already be in flight.
    > 
    > In the other case, honoring the request for a non-visible compositor is
    > more benign, but we can delay it until the compositor is actually
    > visible again. This means if a context is lost, backgrounded tabs would
    > not all attempt to reconnect to the Gpu process at once.
    > 
    > This is a better followup for the hacky
    > https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which
    > was meant only for merge to a release branch. It reverts that change as
    > part of this one.
    > 
    > R=​piman@chromium.org
    > 
    > Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7
    > Bug: 896836, 419087
    > Reviewed-on: https://chromium-review.googlesource.com/c/1292714
    > Commit-Queue: danakj <danakj@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606655}
    
    TBR=danakj@chromium.org,dcheng@chromium.org,piman@chromium.org
    
    Change-Id: I65238aba0abdb6c9192e9f3cb3691f8dd89b3ea5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 896836, 419087, 903696
    Reviewed-on: https://chromium-review.googlesource.com/c/1329003Reviewed-by: default avatarPatrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606807}
    3b39a541
stub_layer_tree_view_delegate.cc 820 Bytes