GitLab

Right now it opens OS settings, which has the same set of sync options
as browser settings. Soon the OS sync settings page will be different,
and we want to send users to the browser settings page either way.

This also helps if a user checks both "Review sync options" and
"Review Google Play options" during OOBE. They will see two windows,
OS settings and browser settings.

Making syncSetup a browser settings, rather than OS settings, subpage
requires changing ARC++ URL handling in ChromeNewWindowClient for
mojo enum ChromePage::SYNCSETUP. I think this is OK, because it's
closer to the original ARC++ behavior before split settings, and
also I can find no usage of the SYNCSETUP code path in the ARC++
code (or anywhere else in google3).

This CL is a partial revert of:
https://chromium-review.googlesource.com/c/chromium/src/+/1977139

Bug: 1054980, 901184
Change-Id: Ide777363aa83e9a7b0f87068c318bd1f274c7e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068948Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743994}