GitLab

The previous (now reverted) version of this CL failed to build in
debug mode (and therefore broke the continuous build), because
apparently static constexpr class members, which must be initialized
in the class definition, are then not available at link time when
is_debug=true.  I didn't catch this before landing the CL because I
was building with is_debug=false.

The fix involved declaring the members as static const (not constexpr),
and defining them in demo_mode_detector.cc.

Revert "Revert "Disable Demo app launch when device is in Dev mode""

This reverts commit 225590d4.

Bug: 877655
Change-Id: Id8c15012e4bfa33230feda38ec8a94ea5c809741
Reviewed-on: https://chromium-review.googlesource.com/c/1318741
Commit-Queue: Danan S <danan@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605950}