• Toni Barzic's avatar
    Improve app list search box accessibility · 3c227087
    Toni Barzic authored
    Increases the delay for announcing search query changes to give
    chromevox more time to announce query changes, and to give search
    results more time to stabilize.
    
    Makes sure the selection moves to the search box text field when the
    user interacts with the search box (e.g. when they change the query).
    This should ensure that the chromevox announces the textfield changes to
    the user. Note that this should be done only if the selection has moved
    to a search result (otherwise ChromeVox would announce the full
    extfield value on each text update). To achieve this,
    SearchResultPageView has to notify the SearchBoxView that it changed the
    current selection - the cl adds a11y_selection_on_search_result_ member
    to the SearchBoxView that is set by SearchResultPageView, and reset by
    SearchBoxView when the selection moves back to the textfield.
    
    Removes calls to notify a11y selection changes from search result views.
    SearchResultPageView already handles result selection changes and sends
    the selection updates, but it also updates the search box state.
    
    Moves the a11y selection to the close button when it's focused.
    
    Updates the search box accessible name when search box is active not to
    reference using keys to navigate apps (as there are no apps to navigate
    when the search box is active).
    
    BUG=1111579
    
    Change-Id: Ib11bcc9122e7545c7a37ad4ea2a6005459ee6176
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476903
    Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#817970}
    3c227087
search_box_view_base.cc 18 KB