• Majid Valipour's avatar
    [usecounter] Add presubmit to check generation of enums entries for css · 3c710adf
    Majid Valipour authored
    Add a PRESUMIT check that ensures when the user has updated
    css_property_id.mojom they are also updating the enums.xml accordingly
    using the expected python script.
    
    The check is similar to the one in web_feature/PRESUMIT.py.
    
    Also removed a defunct PRESUMIT in core/frame that was trying to check
    the validity of max value. We no longer need user to manually enter max
    value so this is no longer needed.
    
    TEST = manually added a new entry in mojom file and not ran the script.
    presubmit check detected this with the following warning. Then running
    the script made the warning go away.
    
    ** Presubmit Warnings **
    MappedCSSProperties enum has been updated and the UMA mapping needs to be regenerated. Please run update_use_counter_css.py in src/tools/metrics/histograms/ to update the mapping.
      third_party/blink/public/mojom/use_counter/css_property_id.mojom
    
    
    Change-Id: I357bad58682c8ac50d67f4929da5e9bca7c08554
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755413
    Commit-Queue: Majid Valipour <majidvp@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#723400}
    3c710adf
update_histogram_enum.py 13.2 KB