• Avi Drissman's avatar
    Add missing dependencies · 3cce8de6
    Avi Drissman authored
    In https://ci.chromium.org/p/chrome/builders/official/mac64/1623:
    
    chrome/browser/extensions/api/omnibox/omnibox_api.h includes
    components/omnibox/browser/autocomplete_match.h includes
    components/omnibox/browser/buildflags.h
    
    This fails due to three bad dependencies.
    
    1. autocomplete_match.h includes buildflags.h, and is included
       from code outside of components/omnibox/browser so buildflags.h
       must be a public_deps
    2. omnibox_api.h includes autocomplete_match.h so it must
       declare it in deps
    3. because omnibox_api.h is further included outside of
       chrome/browser/extensions/api/omnibox, its inclusion of
       autocomplete_match.h means that autocomplete_match.h
       must be a public_deps
    
    (Thanks to rockot@ for the help.)
    
    Bug: 1130293
    Change-Id: Ic08fbc648c9fed70e853b4c8ab1478fe4626a933
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436575Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
    Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#811798}
    3cce8de6
BUILD.gn 50.7 KB