• Elly Fong-Jones's avatar
    flags: refactor FlagsState interface · 3cd75283
    Elly Fong-Jones authored
    This change:
    1) has FlagsState take (and internally store) its set of FeatureEntry as
       a base::span<FeatureEntry> rather than a (FeatureEntry*, size_t) pair,
       and rewrites all iterations over the set of FeatureEntry to use
       new-style for loops.
    2) introduces FlagsState::Delegate for users of the component to
       customize the behavior of FlagsState, and replaces existing uses of
       the exclude predicate with uses of this delegate.
    
    This is a preparatory refactor for the work to show flag expiration
    milestones within the flags UI. As that work proceeds
    FlagsState::Delegate will gain new methods.
    
    Bug: 1020637
    Change-Id: Ia61abb4ba7fe42df874a9089531be69f5b076fc1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912419Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
    Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#714622}
    3cd75283
flags_state.h 10.3 KB