• danakj's avatar
    Improve mac webtest size injection timing · 3dd7a610
    danakj authored
    This changes the hook-up of mac web tests to resize the top level
    RenderWidgetHostView as soon as the renderer-side objects are created
    so that the correct screen rects can be sent to the renderer. Previously
    it was hooked up to the asynchronous RenderViewReady() which made it
    race with the renderer running the test, a race it happened to win. Now
    we do it when
    a) The main RenderFrame is created (along with its renderer-side widget)
    b) A new window/webcontents is created, and it already has a renderer-
       side main frame when it is wrapped in a Shell.
    
    This will allow us to change the browser-side code notifying about
    renderer objects being created without breaking these tests in
    https://chromium-review.googlesource.com/c/chromium/src/+/2597851 .
    
    R=dcheng@chromium.org
    
    Bug: 1158869
    Change-Id: I645d67c705a9390853c052804edbd07eaea91c95
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606520
    Auto-Submit: danakj <danakj@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#839784}
    3dd7a610
shell_platform_delegate.h 5.59 KB