• Sammie Quon's avatar
    Revert "media/gpu/vaapi: Create VAImage with va surface size on UploadVideoFrameToSurface()" · 3e957297
    Sammie Quon authored
    This reverts commit 95ad9e5a.
    
    Reason for revert: crbug.com/1057857
    
    Original change's description:
    > media/gpu/vaapi: Create VAImage with va surface size on UploadVideoFrameToSurface()
    >
    > This is a workaround of the failure at 1080p video encoding
    > test on grunt.
    >
    > Originally vaCreateImage is created with a coded frame size.
    > However, it causes SEGV_MAPERR on vaPutImage, which copies
    > vaImage to vaSurface.
    >
    > As a result of experiments, the vaImage size needs to be the
    > same as va surface size. Since this is not stated in VA-API
    > document, so this might be a bug of AMD gallium driver.
    >
    > Besides of the workaround, this CL copies visible size area
    > of VideoFrame to the VAImage.
    >
    > Bug: 1048908
    > Bug: 1050377
    > Bug: b:148744040
    > Test: video.EncodeAcel.* on grunt, eve and soraka
    > Test: camera.* on grunt, eve and soraka
    > Change-Id: I1ee853964387846d2452e72cfbd4c939f0a18f62
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041382
    > Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#744953}
    
    TBR=hiroh@chromium.org,andrescj@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1048908, 1050377, b:148744040, 1057857
    Change-Id: I21fa0d014fdf2bd18fa2629772fb4b822913c82d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083867Reviewed-by: default avatarSammie Quon <sammiequon@chromium.org>
    Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#746186}
    3e957297
vaapi_video_encode_accelerator.cc 58.7 KB